-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
connector/saml: add redirect binding support #1175
base: master
Are you sure you want to change the base?
Conversation
@ericchiang What do you think? 😉 |
@srenatus this was brought up before. The dex maintainers have no way of testing this. Do we know a provider that we can use? |
@ericchiang I usually make use of Okta's preview sandbox, oktapreview.com. Concretely, I'm using some |
@ericchiang have you had a chance to play with this? 😉 |
Has there been any movement on this? It would open up the possibility for Salesforce employee internal SSO in a big way |
This change adds support for using the "HTTP Redirect Binding" for AuthnRequests. Note that it's uncommon to use the Redirect Binding for consuming assertions. To enable redirect, add redirectBinding: true to your SAML connector's config section. If not set, it will default to the current behaviour, HTTP POST Binding. Signed-off-by: Stephan Renatus <[email protected]>
7514f36
to
6bb255b
Compare
@pbar1 I've resolved the conflicts. By any chance, could you test this using your SAML IdP? 😃 |
I can take a stab at testing it in the coming weeks. Actually rebased myself at the time of my comment just to fiddle around and it seemed to be working. I'll update with the results. Thanks! |
This change adds support for using the "HTTP Redirect Binding" for
AuthnRequests. Note that it's uncommon to use the Redirect Binding for
consuming assertions.
To enable redirect, add
to your SAML connector's config section.
If not set, it will default to the current behaviour, HTTP POST Binding.
Fixes #1169.